]> dgit.raspbian.org Git - gnome-shell.git/commit
keyboard: Plug a leak of KeyboardControllers
authorJonas Dreßler <verdre@v0yd.nl>
Tue, 18 Feb 2020 14:05:57 +0000 (15:05 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Tue, 18 Feb 2020 14:48:39 +0000 (14:48 +0000)
commit45bc8ae292a176603ff2153d8fda8e641114d7d8
treefd8cf1278654149b45ded04753e84967196b4fd7
parentfbfe5a1988107401fda3242841f28c4baec57b1a
keyboard: Plug a leak of KeyboardControllers

To make sure the GC really disposes the KeyboardController object we
need to remove all references to the object, which means we have to
disconnect signals the object connects to, too.

This also fixes a bug where keys remain pressed forever and thus also
break that key on real keyboards. It happens if the OSK gets destroyed
during an OSK-key is being held so the StButton of the key is not
released. That means the key remains pressed in the
MetaVirtualInputDevice that we are now leaking because
KeyboardController isn't garbage collected.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1015
js/ui/keyboard.js